EF-S lenses are a very good and economical choice for cameras that accept them. Before investing in them, however, one should realize the fact that a lens can be a very long-term investment, whereas a digital camera is most likely a short-term investment. Given that, then, you run the risk of buying an EF-S lens that only fits EF-S mounts, which may not be available if you upgrade to a Canon that has the standard mount, whatever that's called. Many folks may keep a camera, even a digital, for a very long time, and for that group maybe an EF-S is a good fit. If, however, you think you may want to upgrade, you might want to consider investing in a lens that is most likely guaranteed (emphasize "most likely") to fit any Canon camera, current and future models.
I have lenses that are 4 and 5 years old that still work great, but I've upgraded my camera three times during that period. I always keep my older cameras thinking I'll use them as back-ups or carry them in the field with a different lens connected to it. Thing is, I almost never use them. Point is, I guess, lenses are forever; cameras, sadly, are not.
Paul Wolf
www.paulwolf.smugmug.com